-
Notifications
You must be signed in to change notification settings - Fork 67
SWIFT-536 Automate building examples in release script #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One problem with this is that it won't ever try to build the changes being released. It'll just verify that the existing examples build against the latest version. A couple of solutions are possible:
I'm not really sure which of these would be the best approach, or really if any of these is the right one. What do you think? |
|
hmmmmm...... I think we should avoid having non-standard |
patrickfreed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted to go for the "messy" route, since the alternative involved us checking if examples worked after we published a release, which would leave broken examples in the repository if anyone ever checked out via a version tag. It ended up being a single simple sed, so the mess isn't too bad.
| echo "On macOS: brew install gnu-sed" | ||
| exit 43 | ||
| fi | ||
| sed="$ETC_DIR/sed.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was moved to a separate script so that I could use it in build-examples.sh.
| echo "================= Building $example_project succeeded =================" | ||
| else | ||
| echo "================= Building $example_project failed =================" | ||
| exit_code=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was updated so that the script attempts to build all examples now, even if prior builds failed.
SWIFT-536